Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): apploader only emits the latest result #2606

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix(cli): apploader only emits the latest result #2606

merged 1 commit into from
Nov 25, 2024

Conversation

eikeland
Copy link
Contributor

Prevent mounting the app 2 times.

Modified Files

AppLoader.tsx

Changes

  • Added import for last operator from rxjs/operators.
  • Updated the initialize subscription to use the last operator.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2024

🦋 Changeset detected

Latest commit: bdd9e42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@equinor/fusion-framework-cli Patch
@equinor/fusion-framework-cookbook-app-react-context-custom-error Patch
@equinor/fusion-framework-cookbook-app-react-context Patch
@equinor/fusion-framework-cookbook-app-react-feature-flag Patch
poc-portal Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 🐞 bug Something isn't working 💾 CLI fusion framework CLI labels Nov 25, 2024
@eikeland eikeland marked this pull request as ready for review November 25, 2024 11:51
@eikeland eikeland requested review from odinr and a team as code owners November 25, 2024 11:51
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.39% 1746 / 444287
🔵 Statements 0.39% 1746 / 444287
🔵 Functions 22.96% 203 / 884
🔵 Branches 37.1% 384 / 1035
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/cli/src/bin/dev-portal/AppLoader.tsx 0% 0% 0% 0% 1-125
Generated in workflow #8097 for commit bdd9e42 by the Vitest Coverage Report Action

@eikeland eikeland merged commit 00fb17d into main Nov 25, 2024
10 checks passed
@eikeland eikeland deleted the fix/cli/apploader/double-app-loader branch November 25, 2024 14:53
@github-actions github-actions bot mentioned this pull request Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asbjornhaland asbjornhaland asbjornhaland approved these changes

@odinr odinr Awaiting requested review from odinr odinr is a code owner

Assignees
No one assigned
Labels
🐞 bug Something isn't working 💾 CLI fusion framework CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eikeland @asbjornhaland